[SYCL][NATIVE_CPU] Update docs for Native CPU compiler pipeline #20042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
force-pushed
the
colin/add_native_cpu_pipeline_docs
branch
2 times, most recently
from
4e43981 to
0e74590
Compare
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
coldav
force-pushed
the
colin/add_native_cpu_pipeline_docs
branch
from
0e74590 to
a742204
Compare
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
coldav
force-pushed
the
colin/add_native_cpu_pipeline_docs
branch
from
a742204 to
5c56997
Compare
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
force-pushed
the
colin/add_native_cpu_pipeline_docs
branch
from
5c56997 to
80bee8b
Compare
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
force-pushed
the
colin/add_native_cpu_pipeline_docs
branch
from
80bee8b to
afe1ace
Compare
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
coldav
force-pushed
the
colin/add_native_cpu_pipeline_docs
branch
from
afe1ace to
7c6e3a8
Compare
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
coldav
force-pushed
the
colin/add_native_cpu_pipeline_docs
branch
from
7c6e3a8 to
3e06d72
Compare
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
coldav
force-pushed
the
colin/add_native_cpu_pipeline_docs
branch
2 times, most recently
from
37c026c to
6092762
Compare
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This integrates the appropriate compiler documentation originally in the oneAPI Construction Kit (OCK) into the NativeCPU compiler pipeline documentation. It has been updated to try to reflect the Native CPU pipeline, and remove some of the references to OCK's structures, as well as moving some of the documentation to markdown files to be consistent with some of the other documentation. Some of it may be irrelevant for Native CPU, and if so this should be updated over time. Support was added for the mermaid flowcharts in the config.
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hvdijk
reviewed
Sep 15, 2025
hvdijk
reviewed
Sep 15, 2025
hvdijk
reviewed
Sep 15, 2025
hvdijk
reviewed
Sep 15, 2025
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Hi @intel/dpcpp-doc-reviewers I need a review. |
|
|
||
| The inner-most function is the original input kernel, which is *wrapped* | ||
| by new functions in successive phases, until it is ready in a form to be | ||
| executed by the Native CPU driver. These include effectively wrapping a `for (wi : wg)` |
There was a problem hiding this comment.
Without additional context, it may not be clear what wg and wi are in this case. I assume it relates to the next paragraph, but if so this last sentence feels a little redundant.
hvdijk
reviewed
Sep 16, 2025
hvdijk
reviewed
Sep 16, 2025
hvdijk
approved these changes
Sep 16, 2025
After recent comments, some updates
|
Hi @steffenlarsen, I'm updated after your comments, I'm not sure how long I'll have the capability to move forward on this, so if it is possible to prioritise the review, I would very much appreciate it. |
steffenlarsen
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Sorry, it took a little while getting through it, even though it was mostly skimming. I Trust that @hvdijk and @uwedolinsky verified the contents, but what I read seems good!
|
@coldav - Is it ready for the merge? |
|
yes it is ready to merge @steffenlarsen @intel/llvm-gatekeepers (no need to keep commit history this time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates the appropriate compiler documentation originally in the oneAPI Construction Kit (OCK) into the NativeCPU compiler pipeline documenation.
It has been updated to try to reflect the Native CPU pipeline, and remove some of the references to OCK's structures, as well as moving some of the documentation to markdown files to be consistent with some of the other documentation.
Some of it may be irrelevant for Native CPU, and if so this should be updated over time.
Support was added for the mermaid flowcharts in the config.